Update authors/contributors spec #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
reviewed
Mar 23, 2021
| } | ||
| ], | ||
| "contributors": ["PythonPerfection"], | ||
| "authors": ["PythonProfessor"], |
There was a problem hiding this comment.
Could we change this second example so it's more visibly different to the first pls?
There was a problem hiding this comment.
Something like this (pushed change)?
iHiD
approved these changes
Mar 23, 2021
coriolinus
reviewed
Mar 23, 2021
| - The `"contributors[].exercism_username"` key is optional | ||
| - The `"contributors[].exercism_username"` key must be a non-empty, non-blank string | ||
| - The `"contributors[].exercism_username"` value is treated case-insensitively | ||
| - The `"contributors"` value must be a non-empty array |
There was a problem hiding this comment.
Requiring that contributors is non-empty is a new requirement in this PR, and it's not obvious that this was intended.
There was a problem hiding this comment.
And it should not have been. This is wrong.
There was a problem hiding this comment.
Will be fixed in https://github.com/exercism/docs/pull/91/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.